Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request refactors authentication documentation and adds support for a "default" value in the github-token-for-extra-empty-commit field to automatically use the GH_AW_CI_TRIGGER_TOKEN magic secret.
Changes:
- Added new dedicated documentation pages (
github-tools.md,auth-projects.mdx,assign-to-copilot.mdx) to improve navigation and clarity - Implemented
getEffectiveCITriggerGitHubTokenhelper function with corresponding tests to support the "default" value for CI trigger tokens - Updated all internal documentation links from monolithic auth page anchors to new dedicated pages
- Simplified CLI help text to reference general authentication documentation
Reviewed changes
Copilot reviewed 30 out of 30 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/workflow/github_token.go | Added getEffectiveCITriggerGitHubToken function to support magic secret fallback |
| pkg/workflow/github_token_test.go | Added comprehensive tests for new CI trigger token function |
| pkg/workflow/create_pull_request.go | Integrated "default" value support for extra empty commit token |
| pkg/workflow/compiler_safe_outputs_job.go | Integrated "default" value support in job-level env vars |
| pkg/workflow/compiler.go | Updated error message URL (contains formatting issue) |
| pkg/parser/schemas/main_workflow_schema.json | Updated schema descriptions to document "default" value option |
| pkg/cli/project_command.go | Simplified authentication help text |
| docs/src/content/docs/reference/github-tools.md | New dedicated page for GitHub tools configuration |
| docs/src/content/docs/reference/auth-projects.mdx | New dedicated page for Projects authentication |
| docs/src/content/docs/reference/assign-to-copilot.mdx | New dedicated page for Copilot agent assignment |
| docs/src/content/docs/reference/auth.mdx | Major refactoring - removed detailed sections now in dedicated pages |
| docs/src/content/docs/reference/triggering-ci.mdx | Updated secret name examples (missing "default" value docs) |
| docs/src/content/docs/reference/safe-outputs.md | Updated links and simplified descriptions |
| docs/src/content/docs/reference/lockdown-mode.md | Updated authentication references (contains bracket issue) |
| docs/src/content/docs/reference/tools.md | Refactored to point to new github-tools page |
| docs/src/content/docs/reference/frontmatter.md | Removed token precedence documentation |
| docs/src/content/docs/reference/faq.md | Updated lockdown mode references |
| docs/src/content/docs/troubleshooting/* | Updated links to new documentation structure |
| docs/src/content/docs/patterns/* | Updated links to new documentation structure |
| docs/src/content/docs/examples/* | Updated links and authentication sections (contains incomplete line) |
| docs/src/content/docs/index.mdx | Updated GitHub integration link |
| docs/src/content/docs/guides/getting-started-mcp.md | Removed authentication section |
| actions/setup/js/extra_empty_commit.cjs | Updated comment to document "default" value |
| .github/aw/create-agentic-workflow.md | Updated GitHub Tools reference link |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
github-tools.md,auth-projects.mdx, andassign-to-copilot.mdxto consolidate and clarify authentication docs for GitHub Tools, Projects, and Copilot agent assignment; major sections removed from the monolithicauth.mdxGH_AW_CI_TRIGGER_TOKEN: Added"default"as a supported value forgithub-token-for-extra-empty-commit, enabling automatic use of theGH_AW_CI_TRIGGER_TOKENmagic secret without explicit configuration; backed by a newgetEffectiveCITriggerGitHubTokenhelper with tests/reference/tools/#github-tools-githubto/reference/github-tools/and from/reference/auth/#...to the new dedicated auth pages across patterns, examples, troubleshooting, and schema descriptions